Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targets block in Package.json to also access veda-ui as npm module #415

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

sandrahoang686
Copy link
Collaborator

Why are you creating this Pull Request?

This pull requests adds the Targets block in the package.json file to get ready for the other build pipeline moving towards accessing veda-ui as a npm module. This is needed before NASA-IMPACT/veda-ui#976 can merge

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 7a9aff7
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/6683fa95e2df3e00092f001c
😎 Deploy Preview https://deploy-preview-415--visex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sandrahoang686 sandrahoang686 requested a review from dzole0311 July 2, 2024 13:03
Copy link
Collaborator

@hanbyul-here hanbyul-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a comment for a bit more context in the other instance repo: NASA-IMPACT#122 (comment)

Thanks for the pr 🙇

@sandrahoang686 sandrahoang686 merged commit ea55312 into develop Jul 2, 2024
6 checks passed
@sandrahoang686 sandrahoang686 deleted the add/targets-packagejson branch July 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants